Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Querycoord will trigger unexpected balance task after restart #38630

Merged
merged 2 commits into from
Dec 25, 2024
Merged

fix: Querycoord will trigger unexpected balance task after restart #38630

merged 2 commits into from
Dec 25, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #38606

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. area/internal-api labels Dec 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 20, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.06%. Comparing base (c731357) to head (84bc435).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
internal/querycoordv2/meta/target.go 66.66% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #38630   +/-   ##
=======================================
  Coverage   81.06%   81.06%           
=======================================
  Files        1381     1381           
  Lines      195246   195273   +27     
=======================================
+ Hits       158274   158297   +23     
- Misses      31368    31375    +7     
+ Partials     5604     5601    -3
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.33% <ø> (ø)
Go 83.05% <82.35%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/querycoordv2/checkers/balance_checker.go 96.26% <100.00%> (+0.30%) ⬆️
internal/querycoordv2/meta/target_manager.go 88.57% <100.00%> (+0.20%) ⬆️
internal/querycoordv2/meta/target.go 90.76% <66.66%> (-4.19%) ⬇️

... and 26 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 20, 2024
@weiliu1031 weiliu1031 closed this Dec 24, 2024
@weiliu1031 weiliu1031 reopened this Dec 24, 2024
@mergify mergify bot removed the ci-passed label Dec 24, 2024
@weiliu1031 weiliu1031 mentioned this pull request Dec 24, 2024
Merged
@mergify mergify bot added the ci-passed label Dec 24, 2024
@weiliu1031 weiliu1031 mentioned this pull request Dec 24, 2024
Closed
@weiliu1031 weiliu1031 force-pushed the fix_balance_after_qc_restarts branch from a57abd9 to c7a347d Compare December 24, 2024 14:08
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Dec 24, 2024
@mergify mergify bot removed the ci-passed label Dec 24, 2024
@weiliu1031 weiliu1031 mentioned this pull request Dec 24, 2024
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 24, 2024

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 24, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: weiliu1031, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot pushed a commit that referenced this pull request Dec 25, 2024
@weiliu1031
fix: [2.4] Querycoord will trigger unexpected balance task after rest…
8fe883f 
…art (#38714)

issue: #38606 
pr: #38630

---------

Signed-off-by: Wei Liu <[email protected]>
@weiliu1031 weiliu1031 force-pushed the fix_balance_after_qc_restarts branch from c7a347d to 84bc435 Compare December 25, 2024 03:08
@sre-ci-robot sre-ci-robot removed the lgtm label Dec 25, 2024
sre-ci-robot pushed a commit that referenced this pull request Dec 25, 2024
@weiliu1031
fix: [2.5] Querycoord will trigger unexpected balance task after rest…
cb0618b 
…art (#38725)

issue: #38606
pr: #38630

Signed-off-by: Wei Liu <[email protected]>
@mergify mergify bot added the ci-passed label Dec 25, 2024
@chyezh
Copy link
Contributor

chyezh commented Dec 25, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit f49d618 into milvus-io:master Dec 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@congqixia congqixia Awaiting requested review from congqixia

Assignees

@chyezh chyezh

@xiaofan-luan xiaofan-luan

Labels
approved area/internal-api ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weiliu1031 @xiaofan-luan @sre-ci-robot @chyezh